avs-device-sdk/Endpoints/test/EndpointAttributeValidation...

302 lines
11 KiB
C++
Raw Normal View History

Version 1.17.0 alexa-client-sdk Changes in this update: **Enhancements** - Added support for [captions for TTS](https://developer.amazon.com/docs/avs-device-sdk/features.html#captions). This enhancement allows you to print onscreen captions for Alexa voice responses. - Added support for [SpeechSynthesizer Interface 1.3](https://developer.amazon.com/docs/alexa-voice-service/speechsynthesizer.html). This interface supports the new `captions` parameter. - Added support for [AudioPlayer Interface 1.3](https://developer.amazon.com/docs/alexa-voice-service/audioplayer.html). This interface supports the new `captions` parameter. - Added support for [Interaction Model 1.2](https://developer.amazon.com/docs/alexa-voice-service/interactionmodel-interface.html). - Added support for [System 2.0](https://developer.amazon.com/en-US/docs/alexa/alexa-voice-service/system.html). - Added support for Alarm Volume Ramp. This feature lets you to fade in alarms for a more pleasant experience. You enable alarm volume ramp in the sample app through the settings menu. - Added support for using certified senders for URI path extensions. This change allows you to specify the URI path extension when sending messages with [`CertifiedSender::sendJSONMessage`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1certified_sender_1_1_certified_sender.html#a4c0706d79717b226ba77d1a9c3280fe6). - Added new [`Metrics`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1avs_common_1_1utils_1_1_metrics.html) interfaces and helper classes. These additions help you create and consume [`Metrics`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1avs_common_1_1utils_1_1_metrics.html) events. - **Interfaces** - `MetricRecorderInterface`, `MetricSinkInterface`. - **Helper Classes** - `DataPointStringBuilder`, `DataPointCounterBuilder`, `DataPointDurationBuilder`, `MetricEventBuilder`. - Added support for the following AVS [endpoint](../avs-device-sdk/endpoints.html) controller capabilities: - [Alexa.ModeController](https://developer.amazon.com/docs/alexa-voice-service/alexa-modecontroller.html) - [Alexa.RangeController](https://developer.amazon.com/docs/alexa-voice-service/alexa-rangecontroller.html) - [Alexa.PowerController](https://developer.amazon.com/docs/alexa-voice-service/alexa-powercontroller.html) - [Alexa.ToggleController](https://developer.amazon.com/docs/alexa-voice-service/alexa-togglecontroller.html) - Added `PowerResourceManagerInterface`. This interface allows the SDK to control power resource levels for components such as the `AudioInputProcessor` and `SpeechSynthesizer`. - Added `AlexaInterfaceCapabilityAgent`. This Capability Agent handles common directives and endpoint controller capabilities support by [`Alexa.AlexaInterface`](../alexa-voice-service/alexa.html). - Added `AlexaInterfaceMessageSenderInterface`. This interface is required to send common events defined by the `Alexa.AlexaInterface` interface. - Added `BufferingComplete` to [`MediaPlayerObserverInterface`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1avs_common_1_1utils_1_1media_player_1_1_media_player_observer_interface.html). This method helps improve performance in poor networking conditions by making sure `MediaPlayer` pre-buffers correctly. - Added `SendDTMF` to `CallManagerInterface`. This method allows you to send DTMF tones during calls. **New build options** - CAPTIONS - **ADDED** [`CAPTIONS`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#captions) - **ADDED** [`LIBWEBVTT_LIB_PATH`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#captions) - **ADDED** [`LIBWEBVTT_INCLUDE_DIR`](https://developer.amazon.com/docs//avs-device-sdk/cmake-parameters.html#captions) - METRICS - **ADDED** [`METRICS`](https://developer.amazon.com/docs//avs-device-sdk/cmake-parameters.html#metrics) - ENDPONTS - **ADDED** [`ENABLE_ALL_ENDPOINT_CONTROLLERS`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_POWER_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_TOGGLE_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_RANGE_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_MODE_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) **New dependencies** - To use captions, you must install a [new dependency](https://developer.amazon.com/docs/avs-device-sdk/dependencies) – the [libwebvtt parsing library](https://github.com/alexa/webvtt). Webvtt is a C/C++ library for interpreting and authoring conformant WebVTT content. WebVTT is a caption and subtitle format designed for use with HTML5 audio and video elements. **Bug fixes** - Fixed [`MimeResponseSink::onReceiveNonMimeData`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1acl_1_1_mime_response_sink.html) [data issue](https://github.com/alexa/avs-device-sdk/issues/1519) that returned invalid data. - Fixed [data type issue](https://github.com/alexa/avs-device-sdk/issues/1519) that incorrectly used `finalResponseCode` instead of [`FinalResponseCodeId`](https://github.com/alexa/avs-device-sdk/blob/master/AVSCommon/Utils/src/LibcurlUtils/LibCurlHttpContentFetcher.cpp#L370). - Fixed [`UrlContentToAttachmentConverter`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1playlist_parser_1_1_url_content_to_attachment_converter.html) issue that used the incorrect range parameter. - Fixed `FinallyGuard` [linking issue](https://github.com/alexa/avs-device-sdk/issues/1517) that caused problems compiling the SDK on iOS. - Fixed a [Bluetooth Capability Agent](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1capability_agents_1_1bluetooth_1_1_bluetooth.html) bug that prevented devices from initializing. **Known Issues** * The WebVTT dependency required for `captions` isn't supported for Windows/Android. * Music playback history isn't displayed in the Alexa app for certain account and device types. * When using Gnu Compiler Collection 8+ (GCC 8+), `-Wclass-memaccess` triggers warnings. You can ignore these, they don't cause the build to fail. * Android error `libDefaultClient.so not found` might occur. Resolve this by upgrading to ADB version 1.0.40. * If a device loses a network connection, the lost connection status isn't returned via local TTS. * ACL encounters issues if it receives audio attachments but doesn't consume them. * `SpeechSynthesizerState` uses `GAINING_FOCUS` and `LOSING_FOCUS` as a workaround for handling intermediate states. * Media steamed through Bluetooth might abruptly stop. To restart playback, resume the media in the source application or toggle next/previous. * If a connected Bluetooth device is inactive, the Alexa app might indicates that audio is playing. * The Bluetooth agent assumes that the Bluetooth adapter is always connected to a power source. Disconnecting from a power source during operation isn't yet supported. * When using some products, interrupted Bluetooth playback might not resume if other content is locally streamed. * `make integration` isn't available for Android. To run Android integration tests, manually upload the test binary and input file and run ADB. * Alexa might truncate the beginning of speech when responding to text-to-speech (TTS) user events. This only impacts Raspberry Pi devices running Android Things with HDMI output audio. * A reminder TTS message doesn't play if the sample app restarts and loses a network connection. Instead, the default alarm tone plays twice. * `ServerDisconnectIntegratonTest` tests are disabled until they are updated to reflect new service behavior. * Bluetooth initialization must complete before connecting devices, otherwise devices are ignored. * The `DirectiveSequencerTest.test_handleBlockingThenImmediatelyThenNonBockingOnSameDialogId` test fails intermittently. * On some devices, Alexa gets stuck in a permanent listening state. Pressing `t` and `h` in the Sample App doesn't exit the listening state. * Exiting the settings menu doesn't provide a message to indicate that you're back in the main menu.
2019-12-10 21:02:09 +00:00
/*
* Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0/
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/
#include <gtest/gtest.h>
#include <AVSCommon/AVS/AVSDiscoveryEndpointAttributes.h>
#include <Endpoints/EndpointAttributeValidation.h>
namespace alexaClientSDK {
namespace endpoints {
namespace test {
using namespace ::testing;
using namespace avsCommon::avs;
class EndpointAttributeValidationTest : public Test {};
static const size_t MIN_SIZE = 1;
/**
* Test for checking valid endpointId.
*/
TEST_F(EndpointAttributeValidationTest, test_validEndpointIdLengthBoundaries) {
std::string minSizeId(MIN_SIZE, 'c');
EXPECT_TRUE(isEndpointIdValid(minSizeId));
std::string maxSizeId(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_IDENTIFIER_LENGTH, 'c');
EXPECT_TRUE(isEndpointIdValid(maxSizeId));
}
/**
* Test for checking invalid endpointId.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidEndpointIdLengthBoundariesReturnsFalse) {
std::string minSizeId(MIN_SIZE - 1, 'c');
EXPECT_FALSE(isEndpointIdValid(minSizeId));
std::string maxSizeId(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_IDENTIFIER_LENGTH + 1, 'c');
EXPECT_FALSE(isEndpointIdValid(maxSizeId));
}
/**
* Test for checking valid endpoint friendly name.
*/
TEST_F(EndpointAttributeValidationTest, test_validFriendlyNameLengthBoundaries) {
std::string minSizeFriendlyName(MIN_SIZE, 'c');
EXPECT_TRUE(isFriendlyNameValid(minSizeFriendlyName));
std::string maxSizeFriendlyName(AVSDiscoveryEndpointAttributes::MAX_FRIENDLY_NAME_LENGTH, 'c');
EXPECT_TRUE(isFriendlyNameValid(maxSizeFriendlyName));
}
/**
* Test for checking invalid endpoint friendly name.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidFriendlyNameLengthBoundariesReturnsFalse) {
std::string minSizeFriendlyName(MIN_SIZE - 1, 'c');
EXPECT_FALSE(isFriendlyNameValid(minSizeFriendlyName));
std::string maxSizeFriendlyName(AVSDiscoveryEndpointAttributes::MAX_FRIENDLY_NAME_LENGTH + 1, 'c');
EXPECT_FALSE(isFriendlyNameValid(maxSizeFriendlyName));
}
/**
* Test for checking valid endpoint description field.
*/
TEST_F(EndpointAttributeValidationTest, test_validDescriptionLengthBoundaries) {
std::string minSizeDescription(MIN_SIZE, 'c');
EXPECT_TRUE(isDescriptionValid(minSizeDescription));
std::string maxSizeDescription(AVSDiscoveryEndpointAttributes::MAX_DESCRIPTION_LENGTH, 'c');
EXPECT_TRUE(isDescriptionValid(maxSizeDescription));
}
/**
* Test for checking invalid endpoint description field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidDescriptionLengthBoundariesReturnsFalse) {
std::string minSizeDescription(MIN_SIZE - 1, 'c');
EXPECT_FALSE(isDescriptionValid(minSizeDescription));
std::string maxSizeDescription(AVSDiscoveryEndpointAttributes::MAX_DESCRIPTION_LENGTH + 1, 'c');
EXPECT_FALSE(isDescriptionValid(maxSizeDescription));
}
/**
* Test for checking valid manufacturer name field.
*/
TEST_F(EndpointAttributeValidationTest, test_validManufacturerNameLengthBoundaries) {
std::string minSizeManufacturerName(MIN_SIZE, 'c');
EXPECT_TRUE(isManufacturerNameValid(minSizeManufacturerName));
std::string maxSizeManufacturerName(AVSDiscoveryEndpointAttributes::MAX_MANUFACTURER_NAME_LENGTH, 'c');
EXPECT_TRUE(isManufacturerNameValid(maxSizeManufacturerName));
}
/**
* Test for checking invalid manufacturer name field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidManufacturerNameLengthBoundariesReturnsFalse) {
std::string minSizeManufacturerName(MIN_SIZE - 1, 'c');
EXPECT_FALSE(isManufacturerNameValid(minSizeManufacturerName));
std::string maxSizeManufacturerName(AVSDiscoveryEndpointAttributes::MAX_MANUFACTURER_NAME_LENGTH + 1, 'c');
EXPECT_FALSE(isManufacturerNameValid(maxSizeManufacturerName));
}
/**
* Test for checking valid manufacturer field.
*/
TEST_F(EndpointAttributeValidationTest, test_validManufacturerAttributeBoundary) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.manufacturer =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH, 'c');
EXPECT_TRUE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking invalid manufacturer field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidManufacturerAttributeBoundaryReturnsFalse) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.manufacturer =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH + 1, 'c');
EXPECT_FALSE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking valid model field.
*/
TEST_F(EndpointAttributeValidationTest, test_validModelAttributeBoundary) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.model = std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH, 'c');
EXPECT_TRUE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking invalid model field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidModelAttributeBoundaryReturnsFalse) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.model = std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH + 1, 'c');
EXPECT_FALSE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking valid serial number field.
*/
TEST_F(EndpointAttributeValidationTest, test_validSerialNumberAttributeBoundary) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.serialNumber =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH, 'c');
EXPECT_TRUE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking invalid serial number field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidSerialNumberAttributeBoundaryReturnsFalse) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.serialNumber =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH + 1, 'c');
EXPECT_FALSE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking valid firmwareVersion field.
*/
TEST_F(EndpointAttributeValidationTest, test_validFirmwareVersionAttributeBoundary) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.firmwareVersion =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH, 'c');
EXPECT_TRUE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking invalid firmwareVersion field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidFirmwareVersionAttributeBoundaryReturnsFalse) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.firmwareVersion =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH + 1, 'c');
EXPECT_FALSE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking valid softwareVersion field.
*/
TEST_F(EndpointAttributeValidationTest, test_validSoftwareVersionAttributeBoundary) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.softwareVersion =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH, 'c');
EXPECT_TRUE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking invalid softwareVersion field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidSoftwareVersionAttributeBoundaryReturnsFalse) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.softwareVersion =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH + 1, 'c');
EXPECT_FALSE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking valid CustomIdentifier field.
*/
TEST_F(EndpointAttributeValidationTest, test_validCustomIdentifierAttributeBoundary) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.customIdentifier =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH, 'c');
EXPECT_TRUE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking invalid CustomIdentifier field.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidCustomIdentifierAttributeBoundaryReturnsFalse) {
AVSDiscoveryEndpointAttributes::AdditionalAttributes attributes;
attributes.customIdentifier =
std::string(AVSDiscoveryEndpointAttributes::MAX_ENDPOINT_ADDITIONAL_ATTRIBUTES_LENGTH + 1, 'c');
EXPECT_FALSE(isAdditionalAttributesValid(attributes));
}
/**
* Test for checking valid cookie data.
*/
TEST_F(EndpointAttributeValidationTest, test_validCookiesSize) {
std::map<std::string, std::string> emptyCookies;
EXPECT_TRUE(areCookiesValid(emptyCookies));
std::map<std::string, std::string> oneCookie{{"name", "value"}};
EXPECT_TRUE(areCookiesValid(oneCookie));
}
/**
* Test for checking invalid cookie data.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidCookiesSizeReturnsFalse) {
std::map<std::string, std::string> cookies;
size_t bytes = 0;
while (bytes < AVSDiscoveryEndpointAttributes::MAX_COOKIES_SIZE_BYTES) {
std::string name = std::to_string(bytes);
std::string value{"value"};
cookies[name] = value;
bytes += name.size() + value.size();
}
EXPECT_FALSE(areCookiesValid(cookies));
}
/**
* Test for checking valid connections data.
*/
TEST_F(EndpointAttributeValidationTest, test_validConnectionsReturnsTrue) {
std::vector<std::map<std::string, std::string>> validConnections;
auto value1 = std::string(AVSDiscoveryEndpointAttributes::MAX_CONNECTIONS_VALUE_LENGTH, 'a');
auto value2 = std::string(AVSDiscoveryEndpointAttributes::MAX_CONNECTIONS_VALUE_LENGTH, 'b');
validConnections.push_back({{"name1", value1}});
validConnections.push_back({{"name2", value2}});
EXPECT_TRUE(areConnectionsValid(validConnections));
std::vector<std::map<std::string, std::string>> emptyConnections;
EXPECT_TRUE(areConnectionsValid(emptyConnections));
}
/**
* Test for checking invalid connections data.
*/
TEST_F(EndpointAttributeValidationTest, test_invalidConnectionsReturnsFalse) {
std::vector<std::map<std::string, std::string>> emptyValueConnections;
auto value1 = std::string(AVSDiscoveryEndpointAttributes::MAX_CONNECTIONS_VALUE_LENGTH, 'a');
emptyValueConnections.push_back({{"name1", value1}});
emptyValueConnections.push_back({{"name2", ""}});
EXPECT_FALSE(areConnectionsValid(emptyValueConnections));
std::vector<std::map<std::string, std::string>> invalidConnections;
auto value2 = std::string(AVSDiscoveryEndpointAttributes::MAX_CONNECTIONS_VALUE_LENGTH + 1, 'b');
invalidConnections.push_back({{"name1", value1}});
invalidConnections.push_back({{"name2", value2}});
EXPECT_FALSE(areConnectionsValid(invalidConnections));
}
} // namespace test
} // namespace endpoints
} // namespace alexaClientSDK