avs-device-sdk/AVSGatewayManager/test/PostConnectVerifyGatewaySen...

244 lines
9.0 KiB
C++
Raw Normal View History

Version 1.17.0 alexa-client-sdk Changes in this update: **Enhancements** - Added support for [captions for TTS](https://developer.amazon.com/docs/avs-device-sdk/features.html#captions). This enhancement allows you to print onscreen captions for Alexa voice responses. - Added support for [SpeechSynthesizer Interface 1.3](https://developer.amazon.com/docs/alexa-voice-service/speechsynthesizer.html). This interface supports the new `captions` parameter. - Added support for [AudioPlayer Interface 1.3](https://developer.amazon.com/docs/alexa-voice-service/audioplayer.html). This interface supports the new `captions` parameter. - Added support for [Interaction Model 1.2](https://developer.amazon.com/docs/alexa-voice-service/interactionmodel-interface.html). - Added support for [System 2.0](https://developer.amazon.com/en-US/docs/alexa/alexa-voice-service/system.html). - Added support for Alarm Volume Ramp. This feature lets you to fade in alarms for a more pleasant experience. You enable alarm volume ramp in the sample app through the settings menu. - Added support for using certified senders for URI path extensions. This change allows you to specify the URI path extension when sending messages with [`CertifiedSender::sendJSONMessage`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1certified_sender_1_1_certified_sender.html#a4c0706d79717b226ba77d1a9c3280fe6). - Added new [`Metrics`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1avs_common_1_1utils_1_1_metrics.html) interfaces and helper classes. These additions help you create and consume [`Metrics`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1avs_common_1_1utils_1_1_metrics.html) events. - **Interfaces** - `MetricRecorderInterface`, `MetricSinkInterface`. - **Helper Classes** - `DataPointStringBuilder`, `DataPointCounterBuilder`, `DataPointDurationBuilder`, `MetricEventBuilder`. - Added support for the following AVS [endpoint](../avs-device-sdk/endpoints.html) controller capabilities: - [Alexa.ModeController](https://developer.amazon.com/docs/alexa-voice-service/alexa-modecontroller.html) - [Alexa.RangeController](https://developer.amazon.com/docs/alexa-voice-service/alexa-rangecontroller.html) - [Alexa.PowerController](https://developer.amazon.com/docs/alexa-voice-service/alexa-powercontroller.html) - [Alexa.ToggleController](https://developer.amazon.com/docs/alexa-voice-service/alexa-togglecontroller.html) - Added `PowerResourceManagerInterface`. This interface allows the SDK to control power resource levels for components such as the `AudioInputProcessor` and `SpeechSynthesizer`. - Added `AlexaInterfaceCapabilityAgent`. This Capability Agent handles common directives and endpoint controller capabilities support by [`Alexa.AlexaInterface`](../alexa-voice-service/alexa.html). - Added `AlexaInterfaceMessageSenderInterface`. This interface is required to send common events defined by the `Alexa.AlexaInterface` interface. - Added `BufferingComplete` to [`MediaPlayerObserverInterface`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1avs_common_1_1utils_1_1media_player_1_1_media_player_observer_interface.html). This method helps improve performance in poor networking conditions by making sure `MediaPlayer` pre-buffers correctly. - Added `SendDTMF` to `CallManagerInterface`. This method allows you to send DTMF tones during calls. **New build options** - CAPTIONS - **ADDED** [`CAPTIONS`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#captions) - **ADDED** [`LIBWEBVTT_LIB_PATH`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#captions) - **ADDED** [`LIBWEBVTT_INCLUDE_DIR`](https://developer.amazon.com/docs//avs-device-sdk/cmake-parameters.html#captions) - METRICS - **ADDED** [`METRICS`](https://developer.amazon.com/docs//avs-device-sdk/cmake-parameters.html#metrics) - ENDPONTS - **ADDED** [`ENABLE_ALL_ENDPOINT_CONTROLLERS`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_POWER_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_TOGGLE_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_RANGE_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) - **ADDED** [`ENABLE_MODE_CONTROLLER`](https://developer.amazon.com/docs/avs-device-sdk/cmake-parameters.html#endpoints) **New dependencies** - To use captions, you must install a [new dependency](https://developer.amazon.com/docs/avs-device-sdk/dependencies) – the [libwebvtt parsing library](https://github.com/alexa/webvtt). Webvtt is a C/C++ library for interpreting and authoring conformant WebVTT content. WebVTT is a caption and subtitle format designed for use with HTML5 audio and video elements. **Bug fixes** - Fixed [`MimeResponseSink::onReceiveNonMimeData`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1acl_1_1_mime_response_sink.html) [data issue](https://github.com/alexa/avs-device-sdk/issues/1519) that returned invalid data. - Fixed [data type issue](https://github.com/alexa/avs-device-sdk/issues/1519) that incorrectly used `finalResponseCode` instead of [`FinalResponseCodeId`](https://github.com/alexa/avs-device-sdk/blob/master/AVSCommon/Utils/src/LibcurlUtils/LibCurlHttpContentFetcher.cpp#L370). - Fixed [`UrlContentToAttachmentConverter`](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1playlist_parser_1_1_url_content_to_attachment_converter.html) issue that used the incorrect range parameter. - Fixed `FinallyGuard` [linking issue](https://github.com/alexa/avs-device-sdk/issues/1517) that caused problems compiling the SDK on iOS. - Fixed a [Bluetooth Capability Agent](https://alexa.github.io/avs-device-sdk/classalexa_client_s_d_k_1_1capability_agents_1_1bluetooth_1_1_bluetooth.html) bug that prevented devices from initializing. **Known Issues** * The WebVTT dependency required for `captions` isn't supported for Windows/Android. * Music playback history isn't displayed in the Alexa app for certain account and device types. * When using Gnu Compiler Collection 8+ (GCC 8+), `-Wclass-memaccess` triggers warnings. You can ignore these, they don't cause the build to fail. * Android error `libDefaultClient.so not found` might occur. Resolve this by upgrading to ADB version 1.0.40. * If a device loses a network connection, the lost connection status isn't returned via local TTS. * ACL encounters issues if it receives audio attachments but doesn't consume them. * `SpeechSynthesizerState` uses `GAINING_FOCUS` and `LOSING_FOCUS` as a workaround for handling intermediate states. * Media steamed through Bluetooth might abruptly stop. To restart playback, resume the media in the source application or toggle next/previous. * If a connected Bluetooth device is inactive, the Alexa app might indicates that audio is playing. * The Bluetooth agent assumes that the Bluetooth adapter is always connected to a power source. Disconnecting from a power source during operation isn't yet supported. * When using some products, interrupted Bluetooth playback might not resume if other content is locally streamed. * `make integration` isn't available for Android. To run Android integration tests, manually upload the test binary and input file and run ADB. * Alexa might truncate the beginning of speech when responding to text-to-speech (TTS) user events. This only impacts Raspberry Pi devices running Android Things with HDMI output audio. * A reminder TTS message doesn't play if the sample app restarts and loses a network connection. Instead, the default alarm tone plays twice. * `ServerDisconnectIntegratonTest` tests are disabled until they are updated to reflect new service behavior. * Bluetooth initialization must complete before connecting devices, otherwise devices are ignored. * The `DirectiveSequencerTest.test_handleBlockingThenImmediatelyThenNonBockingOnSameDialogId` test fails intermittently. * On some devices, Alexa gets stuck in a permanent listening state. Pressing `t` and `h` in the Sample App doesn't exit the listening state. * Exiting the settings menu doesn't provide a message to indicate that you're back in the main menu.
2019-12-10 21:02:09 +00:00
/*
* Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0/
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/
#include <future>
#include <memory>
#include <thread>
#include <gmock/gmock.h>
#include <AVSCommon/SDKInterfaces/MockPostConnectSendMessage.h>
#include <AVSCommon/Utils/JSON/JSONUtils.h>
#include <AVS/include/AVSCommon/AVS/MessageRequest.h>
#include <AVSGatewayManager/PostConnectVerifyGatewaySender.h>
namespace alexaClientSDK {
namespace avsGatewayManager {
namespace test {
using namespace ::testing;
using namespace avsCommon::avs;
using namespace avsCommon::sdkInterfaces;
using namespace avsCommon::sdkInterfaces::test;
using namespace avsCommon::utils::json::jsonUtils;
/// String indicating the VerifyGateway event's expected namespace.
static const std::string EXPECTED_NAMESPACE = "Alexa.ApiGateway";
/// String indicating the VerifyGateway event's expected name.
static const std::string EXPECTED_NAME = "VerifyGateway";
/// String indicating the VerifyGateway event's expected payload.
static const std::string EXPECTED_PAYLOAD = "{}";
/// Number of retries used in tests.
static const int TEST_RETRY_COUNT = 3;
/**
* Test harness for @c PostConnectVerifyGatewaySender class.
*/
class PostConnectVerifyGatewaySenderTest : public Test {
public:
/// Setup the test harness for running the test.
void SetUp() override;
/// Clean up the test harness after running the test.
void TearDown() override;
protected:
/// flag that will be set when the callback method is called.
bool m_callbackCheck;
/**
* Callback that will be called when the postConnectVerifyGatewaySender receives a successful response.
*
* @param postConnectVerifyGatewaySender The @c PostConnectVerifyGatewaySender instance.
*/
void updateStateCallback(std::shared_ptr<PostConnectVerifyGatewaySender> postConnectVerifyGatewaySender);
/// The instance of the @c PostConnectVerifyGatewaySender that will be used in the tests.
std::shared_ptr<PostConnectVerifyGatewaySender> m_postConnectVerifyGatewaySender;
/// The executor thread to run @c MockPostConnectSendMessage.
std::thread m_mockPostConnectSenderThread;
/// The mock @c PostConnectSendMessage used to test.
std::shared_ptr<MockPostConnectSendMessage> m_mockPostConnectSendMessage;
};
struct EventData {
std::string namespaceString;
std::string nameString;
std::string payloadString;
};
bool parseEventJson(const std::string& eventJson, EventData* eventData) {
std::string eventString;
if (!retrieveValue(eventJson, "event", &eventString)) {
return false;
}
std::string headerString;
if (!retrieveValue(eventString, "header", &headerString)) {
return false;
}
if (!retrieveValue(headerString, "namespace", &eventData->namespaceString)) {
return false;
}
if (!retrieveValue(headerString, "name", &eventData->nameString)) {
return false;
}
if (!retrieveValue(eventString, "payload", &eventData->payloadString)) {
return false;
}
return true;
}
bool validateEvent(const std::string& eventJson) {
EventData eventData;
if (!parseEventJson(eventJson, &eventData)) {
return false;
}
if (eventData.nameString != EXPECTED_NAME || eventData.namespaceString != EXPECTED_NAMESPACE ||
eventData.payloadString != EXPECTED_PAYLOAD) {
return false;
}
return true;
}
void PostConnectVerifyGatewaySenderTest::SetUp() {
m_callbackCheck = false;
m_mockPostConnectSendMessage = std::make_shared<NiceMock<MockPostConnectSendMessage>>();
auto callback = std::bind(&PostConnectVerifyGatewaySenderTest::updateStateCallback, this, std::placeholders::_1);
m_postConnectVerifyGatewaySender = PostConnectVerifyGatewaySender::create(callback);
}
void PostConnectVerifyGatewaySenderTest::TearDown() {
if (m_mockPostConnectSenderThread.joinable()) {
m_mockPostConnectSenderThread.join();
}
}
void PostConnectVerifyGatewaySenderTest::updateStateCallback(
std::shared_ptr<PostConnectVerifyGatewaySender> postConnectVerifyGatewaySender) {
if (postConnectVerifyGatewaySender == m_postConnectVerifyGatewaySender) {
m_callbackCheck = true;
}
}
/**
* Test if the create method fails
*/
TEST_F(PostConnectVerifyGatewaySenderTest, test_creaetWithEmptyCallbackMethod) {
std::function<void(const std::shared_ptr<PostConnectVerifyGatewaySender>&)> callback;
auto instance = PostConnectVerifyGatewaySender::create(callback);
}
/**
* Test happy path where performGateway returns true when VerifyGateway event is sent and 204 response is received.
*/
TEST_F(PostConnectVerifyGatewaySenderTest, test_performGatewayWhen204IsReceived) {
auto sendMessageLambda = [this](std::shared_ptr<MessageRequest> request) {
if (m_mockPostConnectSenderThread.joinable()) {
m_mockPostConnectSenderThread.join();
}
m_mockPostConnectSenderThread = std::thread([request]() {
EXPECT_TRUE(validateEvent(request->getJsonContent()));
request->sendCompleted(MessageRequestObserverInterface::Status::SUCCESS_NO_CONTENT);
});
};
EXPECT_CALL(*m_mockPostConnectSendMessage, sendPostConnectMessage(_)).WillOnce(Invoke(sendMessageLambda));
ASSERT_TRUE(m_postConnectVerifyGatewaySender->performOperation(m_mockPostConnectSendMessage));
ASSERT_TRUE(m_callbackCheck);
}
/**
* Test if performGateway returns false when VerifyGateway event is sent and 200 response is received.
*/
TEST_F(PostConnectVerifyGatewaySenderTest, test_performGatewayWhen200IsReceived) {
auto sendMessageLambda = [this](std::shared_ptr<MessageRequest> request) {
if (m_mockPostConnectSenderThread.joinable()) {
m_mockPostConnectSenderThread.join();
}
m_mockPostConnectSenderThread = std::thread([request]() {
EXPECT_TRUE(validateEvent(request->getJsonContent()));
request->sendCompleted(MessageRequestObserverInterface::Status::SUCCESS);
});
};
EXPECT_CALL(*m_mockPostConnectSendMessage, sendPostConnectMessage(_)).WillOnce(Invoke(sendMessageLambda));
ASSERT_TRUE(m_postConnectVerifyGatewaySender->performOperation(m_mockPostConnectSendMessage));
ASSERT_FALSE(m_callbackCheck);
}
/**
* Test if performGateway returns false when VerifyGateway event is sent and 400 response is received.
*/
TEST_F(PostConnectVerifyGatewaySenderTest, test_performGatewayWhen400IsReceived) {
auto sendMessageLambda = [this](std::shared_ptr<MessageRequest> request) {
if (m_mockPostConnectSenderThread.joinable()) {
m_mockPostConnectSenderThread.join();
}
m_mockPostConnectSenderThread = std::thread([request]() {
EXPECT_TRUE(validateEvent(request->getJsonContent()));
request->sendCompleted(MessageRequestObserverInterface::Status::BAD_REQUEST);
});
};
EXPECT_CALL(*m_mockPostConnectSendMessage, sendPostConnectMessage(_)).WillOnce(Invoke(sendMessageLambda));
ASSERT_FALSE(m_postConnectVerifyGatewaySender->performOperation(m_mockPostConnectSendMessage));
ASSERT_FALSE(m_callbackCheck);
}
/**
* Test if performGateway retries sending VerifyGateway event when a 5xx response is received.
*/
TEST_F(PostConnectVerifyGatewaySenderTest, test_performGatewayRetriesWhen503IsReceived) {
std::promise<int> retryCountPromise;
auto sendMessageLambda = [this, &retryCountPromise](std::shared_ptr<MessageRequest> request) {
if (m_mockPostConnectSenderThread.joinable()) {
m_mockPostConnectSenderThread.join();
}
m_mockPostConnectSenderThread = std::thread([this, request, &retryCountPromise]() {
EXPECT_TRUE(validateEvent(request->getJsonContent()));
request->sendCompleted(MessageRequestObserverInterface::Status::SERVER_INTERNAL_ERROR_V2);
static int count = 0;
count++;
if (TEST_RETRY_COUNT == count) {
retryCountPromise.set_value(count);
std::thread localThread([this]() { m_postConnectVerifyGatewaySender->abortOperation(); });
if (localThread.joinable()) {
localThread.join();
}
}
});
};
EXPECT_CALL(*m_mockPostConnectSendMessage, sendPostConnectMessage(_)).WillRepeatedly(Invoke(sendMessageLambda));
ASSERT_FALSE(m_postConnectVerifyGatewaySender->performOperation(m_mockPostConnectSendMessage));
EXPECT_EQ(retryCountPromise.get_future().get(), TEST_RETRY_COUNT);
ASSERT_FALSE(m_callbackCheck);
}
} // namespace test
} // namespace avsGatewayManager
} // namespace alexaClientSDK